On Tue, Aug 27, 2024 at 10:53:40AM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong <djwong@xxxxxxxxxx> > > On error, blkdev_issue_write_zeroes used to recheck the block device's > WRITE SAME queue limits after submitting WRITE SAME bios. As stated in > the comment, the purpose of this was to collapse all IO errors to > EOPNOTSUPP if the effect of issuing bios was that WRITE SAME got turned > off in the queue limits. Therefore, it does not make sense to reuse the > zeroes limit that was read earlier in the function because we only care > about the queue limit *now*, not what it was at the start of the > function. Yes, that was a bit overeager.. Looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>
