On Tue, Aug 27, 2024 at 04:33:58PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong <djwong@xxxxxxxxxx> > > Several people reported C++ compilation errors due to things that C > compilers allow but C++ compilers do not. Fix both of these problems, > and hope there aren't more of these brown paper bags in 2 months when we > finally get these fixes through the process into a released xfsprogs. Meh. I hate these stupid constrains C++ places on but which we need to care for :( Maybe also put a comment into xfs_fs.h that it needs to be C++-clean? Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>