On Sat, Aug 24, 2024 at 06:50:04AM +0200, Christoph Hellwig wrote: > On Fri, Aug 23, 2024 at 09:47:18PM -0700, Darrick J. Wong wrote: > > > + * data when the entire mapping is in the process of being overwritten > > > + * using the out of place write path. This is undone in after > > > > Nit: "...undone after xfs_bmapi_remap..." > > It's actually undone inside xfs_bmapi_remap, and has to because that > clears the blockcount to zero. "This is undone inside xfs_bmapi_remap after it has incremented di_nblocks for a successful operation." (and you can still add the rvb) --D