On Fri, Aug 23, 2024 at 07:04:35PM +0800, Long Li wrote: > ip->i_itemp has been set null in xfs_inode_item_destroy(), so there is > no need set it null again in xfs_inode_free_callback(). > > Signed-off-by: Long Li <leo.lilong@xxxxxxxxxx> Seems reasonable, Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx> --D > --- > fs/xfs/xfs_icache.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/xfs/xfs_icache.c b/fs/xfs/xfs_icache.c > index cf629302d48e..a5e5e5520a3b 100644 > --- a/fs/xfs/xfs_icache.c > +++ b/fs/xfs/xfs_icache.c > @@ -143,7 +143,6 @@ xfs_inode_free_callback( > ASSERT(!test_bit(XFS_LI_IN_AIL, > &ip->i_itemp->ili_item.li_flags)); > xfs_inode_item_destroy(ip); > - ip->i_itemp = NULL; > } > > kmem_cache_free(xfs_inode_cache, ip); > -- > 2.39.2 > >
