On 22/08/2024 21:38, Darrick J. Wong wrote:
This (atomicwrites && !forcealign) ought to be checked in the superblock
verifier.
You mean in xfs_fs_validate_params(), right?
xfs_validate_sb_common, where we do all the other ondisk superblock
validation.
I don't see any other xfs_has_XXX checks in xfs_validate_sb_common(),
but this could be the first...
The only other place in which I see a pattern of similar SB feature flag
checks is in xfs_finish_flags() for checking xfs_has_crc() &&
xfs_has_noattr2().
So if we go with xfs_validate_sb_common(), then should the check in
xfs_fs_fill_super() for xfs_has_forcealign() &&
xfs_has_realtime()/reflink() be relocated to xfs_validate_sb_common() also:
https://lore.kernel.org/linux-xfs/20240813163638.3751939-8-john.g.garry@xxxxxxxxxx/
Cheers,
John
