On Wed, Aug 21, 2024 at 09:07:23AM -0700, Darrick J. Wong wrote: > On Tue, Aug 20, 2024 at 07:04:57PM +0200, Christoph Hellwig wrote: > > Currently the debug-only xfs_bmap_exact_minlen_extent_alloc allocation > > variant fails to drop into the lowmode last restor allocator, and > > last resort? Yes. > > + /* > > + * Use the low space allocator as it first does a "normal" AG iteration > > + * and then drops the reservation to minlen, which might be required to > > + * find an allocation for the transaction reservation when the file > > + * system is very full. > > Isn't it already doing a minlen allocation? Oh, that probably refers to > shrinking args->total, doesn't it. Yes, without this patch ap->total is left at the full value and never reduced.