On Tue, Aug 20, 2024 at 07:04:56PM +0200, Christoph Hellwig wrote: > xfs_bmap_exact_minlen_extent_alloc duplicates the args setup in > xfs_bmap_btalloc. Switch to call it from xfs_bmap_btalloc after > doing the basic setup. And the buildbot correctly points out that we want the following fixup for non-DEBUG builds: diff --git a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c index 03b23875330734..0f793673d73dcb 100644 --- a/fs/xfs/libxfs/xfs_bmap.c +++ b/fs/xfs/libxfs/xfs_bmap.c @@ -3543,9 +3543,13 @@ xfs_bmap_exact_minlen_extent_alloc( return xfs_bmap_btalloc_low_space(ap, args); } #else - -#define xfs_bmap_exact_minlen_extent_alloc(bma) (-EFSCORRUPTED) - +static int +xfs_bmap_exact_minlen_extent_alloc( + struct xfs_bmalloca *ap, + struct xfs_alloc_arg *args) +{ + BUILD_BUG_ON(1); +} #endif /*