On Mon, Aug 19, 2024 at 07:09:32AM -0700, Christoph Hellwig wrote: > On Mon, Aug 19, 2024 at 03:22:05PM +0200, cem@xxxxxxxxxx wrote: > > From: Carlos Maiolino <cem@xxxxxxxxxx> > > > > The new xfs_io fs properties subcommand, requires fsprops to be build, > > while libfrog conditionally build it according to the existence of > > libattr. > > > > This causes builds to fail if the libattr headers are not available, > > without a clear output. > > > > Now that xfs_io unconditionally requires libfrog/fsprops.c to be built, > > remove the condition from libfrog's Makefile. > > That means we'll also need to make libattr mandatory in configure, > right? How about we just opencode ATTR_ENTRY in libfrog and then we can get rid of the libattr dependency for it and xfs_scrub? IIRC that's the only piece of libattr that those pieces actually need. --D
