On 2024/8/17 12:48, Matthew Wilcox wrote: > On Mon, Aug 12, 2024 at 08:11:58PM +0800, Zhang Yi wrote: >> +++ b/fs/iomap/buffered-io.c >> @@ -744,8 +744,8 @@ static int __iomap_write_begin(const struct iomap_iter *iter, loff_t pos, >> poff, plen, srcmap); >> if (status) >> return status; >> + iomap_set_range_uptodate(folio, poff, plen); >> } >> - iomap_set_range_uptodate(folio, poff, plen); >> } while ((block_start += plen) < block_end); > > Um, what I meant was to just delete the iomap_set_range_uptodate() > call in __iomap_write_begin() altogether. We'll call it soon enough in > __iomap_write_end(). > Yeah! Looks reasonable to me. Thanks, Yi.