Re: [PATCH 2/5] add a new min_dio_alignment helper

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 13, 2024 at 07:40:04AM -0700, Darrick J. Wong wrote:
> > +	/*
> > +	 * No support for STATX_DIOALIGN and not a block device:
> > +	 * default to PAGE_SIZE.
> 
> Should we try DIOINFO here as a second to last gasp?

I implemented this last night, but have second thoughts now:

DIOINFO is only implemented for XFS, which both implemented
STATX_DIOALIGN from the start, and where the block size hack works
and is equivalent to the DIOINFO output.  So I don't think this
buys us anything but costs an extra syscall per invocation.

So I plan to drop this again before submission.





[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux