On Tue, Aug 13, 2024 at 04:59:25PM +0200, Christoph Hellwig wrote: > On Tue, Aug 13, 2024 at 07:19:28PM +1000, Dave Chinner wrote: > > In hindsight, this was a wholly avoidable bug - a single patch made > > two different API modifications that only differed by a single > > letter, and one of the 23 conversions missed a single letter. If > > that was two patches - one for the finobt conversion, the second for > > the inobt conversion, the bug would have been plainly obvious during > > review.... > > Maybe we should avoid identifiers that close anyway :) > > The change looks good: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> Looks good to me too Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx> --D