Re: [PATCH] xfs_scrub: Use POSIX-conformant strerror_r

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> +++ b/scrub/inodes.c
> @@ -65,9 +65,9 @@ bulkstat_for_inumbers(
>  	error = -xfrog_bulkstat(&ctx->mnt, breq);
>  	if (error) {
>  		char	errbuf[DESCR_BUFSZ];
> +		strerror_r(error, errbuf, DESCR_BUFSZ);
>  
> -		str_info(ctx, descr_render(dsc), "%s",
> -			 strerror_r(error, errbuf, DESCR_BUFSZ));
> +		str_info(ctx, descr_render(dsc), "%s", errbuf);

Please keep an empty line after the variable declaration.  I'd
skip the one between the strerror_r and str_info calls instead,
though.

Otherwise this looks good to me.




[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux