On Thu, Aug 08, 2024 at 07:48:33AM +0000, John Garry wrote: > The values in fsx_extsize and fsx_cowextsize are in units of bytes, and not > filesystem blocks, so update. > > In addition, the default cowextsize is 32 filesystem blocks, not 128, so > fix that as well. > > Signed-off-by: John Garry <john.g.garry@xxxxxxxxxx> Yep, that's been wrong for a while. :( Thanks for fixing the docs, Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx> --D > > diff --git a/man/man2/ioctl_xfs_fsgetxattr.2 b/man/man2/ioctl_xfs_fsgetxattr.2 > index 2c626a7e..25a9ba79 100644 > --- a/man/man2/ioctl_xfs_fsgetxattr.2 > +++ b/man/man2/ioctl_xfs_fsgetxattr.2 > @@ -40,7 +40,7 @@ below for more information. > .PP > .I fsx_extsize > is the preferred extent allocation size for data blocks mapped to this file, > -in units of filesystem blocks. > +in units of bytes. > If this value is zero, the filesystem will choose a default option, which > is currently zero. > If > @@ -62,9 +62,9 @@ is the project ID of this file. > .PP > .I fsx_cowextsize > is the preferred extent allocation size for copy on write operations > -targeting this file, in units of filesystem blocks. > +targeting this file, in units of bytes. > If this field is zero, the filesystem will choose a default option, > -which is currently 128 filesystem blocks. > +which is currently 32 filesystem blocks. > If > .B XFS_IOC_FSSETXATTR > is called with > -- > 2.31.1 > >
