On Wed, Aug 07, 2024 at 02:50:18PM +0100, John Garry wrote: > On 06/08/2024 20:43, Darrick J. Wong wrote: > > On Thu, Aug 01, 2024 at 04:30:57PM +0000, John Garry wrote: > > > From: "Darrick J. Wong"<djwong@xxxxxxxxxx> > > > > > > Enable this feature. > > > > > > Signed-off-by: "Darrick J. Wong"<djwong@xxxxxxxxxx> > > > Signed-off-by: John Garry<john.g.garry@xxxxxxxxxx> > > You really ought to add your own Reviewed-by tag here... > > ok, if you prefer. Normally I think it's implied by the context and > signed-off tag. SoB means only that either you've written the patch yourself and have the right to submit it, or that you have the right to pass on a patch written by someone else who certified the same thing. An actual code review should be signalled explicitly, not implied by context. --D > Thanks, > John >