On Tue, Jul 30, 2024 at 02:38:08PM -0700, Christoph Hellwig wrote: > On Mon, Jul 29, 2024 at 08:20:45PM -0700, Darrick J. Wong wrote: > > From: Darrick J. Wong <djwong@xxxxxxxxxx> > > > > Hoist the listxattr code from xfs_repair so that we can use it in > > xfs_db. > > I guess there isn't much of a point in sharing with the kernel listattr > code? > > But maybe that is for later, for now this trivial move looks good: I think we could do it. The major difference between the two is the prefix we use for the dabno "have I seen this block before?" bitmap functions. But that and the scrub/listxattr.c code would both have to be lifted to libxfs, and as long as we're doing that we might as well clean up the userspace bitmap implementation. (IOWs that's a somewhat lengthy cleanup for userspace either for after we get the rt modernization stuff merged or if we get really bored sitting in meetings.) > Reviewed-by: Christoph Hellwig <hch@xxxxxx> Thank you! --D
