> On Tue, Jul 30, 2024 at 03:56:53PM +0800, Ma Xinjian wrote:
> > This test requires a kernel patch since 3bf963a6c6 ("xfs/348:
> > partially revert dbcc549317"), so note that in the test.
> >
> > Signed-off-by: Ma Xinjian <maxj.fnst@xxxxxxxxxxx>
> > ---
> > tests/xfs/348 | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/tests/xfs/348 b/tests/xfs/348 index 3502605c..e4bc1328
> > 100755
> > --- a/tests/xfs/348
> > +++ b/tests/xfs/348
> > @@ -12,6 +12,9 @@
> > . ./common/preamble
> > _begin_fstest auto quick fuzzers repair
> >
> > +_fixed_by_git_commit kernel 38de567906d95 \
> > + "xfs: allow symlinks with short remote targets"
>
> Considering that 38de567906d95 is itself a fix for 1eb70f54c445f, do we want a
> _broken_by_git_commit to warn people not to apply 1eb70 without also
> applying 38de5?
Some released Linux OS should have applied 1eb70, so for the test on these OS, the error is indeed caused by the lack of 38de5.
IMO, it should be rare to apply 38de5 without applying 1eb70. So, It will be OK to use _fixed_by_git_commit.
What do you think?
>
> --D
>
> > +
> > # Import common functions.
> > . ./common/filter
> > . ./common/repair
> > --
> > 2.42.0
> >
> >
