> +static int attr_get_f(int argc, char **argv); > static int attr_set_f(int argc, char **argv); > static int attr_remove_f(int argc, char **argv); > +static void attrget_help(void); > static void attrset_help(void); I always hate these forward declarations, but I guess it matches the existing code.. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>