Hi all, I've been running some tests with forced large log sizes, and forced sector sizes, and get a fair amount of failures because these options collide with options forced by the tests themselves. The series here was my attempt to fix this by not failing the tests in this case but _notrun them and print the options that caused them to fail. While writing up this cover letter I realized that the scratch fs options are much deeper mess than that, so this approach might not be what we actually want, but I though to send it out for comments anyway. So what could we do instead? We might distinguish better between tests that just want to create a scratch file system with $MKFS_OPTIONS from the xfstests config, and those (file system specific ones) that want to force very specific file system configurations. How do we get there? A first step might be to split up _scratch_mkfs into a plain _scratch_mkfs that never takes any options, and a _scratch_mkfs_opts that takes options. The former should never fail as that would be a grave error rendering all $SCRATCH_DEV based tests useless. The latter can and should _notrun when the options conflict, or they might be able to do some limited filtering to reduce the amount of conflict, but I suspect that is kinda futile. Last but not least we should probably kill the separate _scratch_mkfs_xfs (and _scratch_mkfs_ext4) which is used rather inconsistently.
