Re: [PATCH] xfs: honor init_xattrs in xfs_init_new_inode for !attr && attr2 fs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 12, 2024 at 10:31:57AM +1000, Dave Chinner wrote:
> Suggesting that someone else should do the work to tidy up the loose
> on-disk format ends in the kernel and userspace in preference to a
> one line hack that works around the problem goes against all the
> agreements we've had for bringing experimental code up to production
> quality. This isn't how to engineer high quality, robust long lived
> code...

I don't think it is entirely unreasonable.  The code works totally
fine by not forcing attr for parent as Darrick pointed out.  It's
also kinda suboptimal and stupid as you pointed out.  So if you care
about it, just sending a patch would be a lot nicer than ranting.





[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux