Hi,
On current xfs-linux' for-next (i.e. commit
49cdc4e834e46d7c11a91d7adcfa04f56d19efaf), xfs/057 caused umount to execute in
an infinite loop inside the kernel. The following was obtained by 'perf
record/report',
24.39% [kernel.kallsyms] [k] __lock_acquire.constprop.0
|
--24.13%--0
|
--24.12%--0x7f939ab4e8ab
entry_SYSCALL_64
do_syscall_64
syscall_exit_to_user_mode
task_work_run
cleanup_mnt
deactivate_locked_super
xfs_kill_sb
kill_block_super
generic_shutdown_super
xfs_fs_put_super
xfs_unmountfs
xfs_unmount_flush_inodes
xfs_reclaim_inodes
|
--24.01%--xfs_icwalk
|
--23.79%--xfs_icwalk_ag
|
|--17.47%--xfs_reclaim_inode
| |
| |--11.71%--_raw_spin_lock
| | |
| | --11.71%--lock_acquire.part.0.isra.0
| | |
| | --11.70%--__lock_acquire.constprop.0
| |
| --5.72%--xfs_ilock_nowait
| down_write_trylock
| |
| --5.71%--lock_acquire.part.0.isra.0
| |
| --5.71%--__lock_acquire.constprop.0
|
--5.98%--_raw_spin_lock
|
--5.98%--lock_acquire.part.0.isra.0
__lock_acquire.constprop.0
I noticed that 66 xfs inodes had XFS_IFLUSHING flag set and the flag is never
cleared. This causes xfs_reclaim_inode() to return back to the caller without
freeing these inodes.
Unfortunately, I am unable to recreate the bug.
The following is from the dmesg log:
[11154.874186] run fstests xfs/057 at 2024-07-05 04:23:26
[11155.685899] XFS (loop16): Mounting V5 Filesystem 0313cedd-1cea-4c58-9fde-6cf7896ac67c
[11155.700962] XFS (loop16): Ending clean mount
[11155.971856] XFS (loop5): Mounting V5 Filesystem 7c161a2e-e85a-4f29-91c3-5ef1bbd92f14
[11155.981646] XFS (loop5): Ending clean mount
[11155.984130] XFS (loop5): Quotacheck needed: Please wait.
[11155.997672] XFS (loop5): Quotacheck: Done.
[11188.028961] XFS (loop5): Unmounting Filesystem 7c161a2e-e85a-4f29-91c3-5ef1bbd92f14
[11191.038552] XFS (loop5): Mounting V5 Filesystem 7c161a2e-e85a-4f29-91c3-5ef1bbd92f14
[11191.052389] XFS (loop5): Ending clean mount
[11221.299133] XFS (loop5): Injecting error (false) at file fs/xfs/xfs_log.c, line 1849, on filesystem "loop5"
[11221.302411] XFS (loop5): Intentionally corrupted log record at LSN 0x1000250d3. Shutdown imminent.
[11221.304993] XFS (loop5): Injecting error (false) at file fs/xfs/xfs_log.c, line 1849, on filesystem "loop5"
[11221.307158] XFS (loop5): Intentionally corrupted log record at LSN 0x100025113. Shutdown imminent.
[11221.309697] XFS (loop5): log I/O error -5
[11221.309807] XFS (loop5): Injecting error (false) at file fs/xfs/xfs_log.c, line 1849, on filesystem "loop5"
[11221.311068] XFS (loop5): log I/O error -5
[11221.311076] XFS (loop5): Filesystem has been shut down due to log error (0x2).
[11221.311081] XFS (loop5): Please unmount the filesystem and rectify the problem(s).
[11221.321602] XFS (loop5): Intentionally corrupted log record at LSN 0x100025153. Shutdown imminent.
[11222.109007] XFS (loop5): Unmounting Filesystem 7c161a2e-e85a-4f29-91c3-5ef1bbd92f14
The following is the fstests configuration used for testing:
FSTYP=xfs
TEST_DIR=/media/test
SCRATCH_MNT=/media/scratch
DUMP_CORRUPT_FS=1
RECREATE_TEST_DEV=true
TEST_DEV=/dev/loop16
TEST_LOGDEV=/dev/loop13
SCRATCH_DEV_POOL="/dev/loop5 /dev/loop6 /dev/loop7 /dev/loop8 /dev/loop9 /dev/loop10 /dev/loop11 /dev/loop12"
MKFS_OPTIONS='-f -m crc=1,reflink=0,rmapbt=0, -i sparse=0 -lsize=1g'
TEST_FS_MOUNT_OPTS="-o logdev=/dev/loop13"
MOUNT_OPTIONS='-o usrquota,grpquota,prjquota'
TEST_FS_MOUNT_OPTS="$TEST_FS_MOUNT_OPTS -o usrquota,grpquota,prjquota"
SCRATCH_LOGDEV=/dev/loop15
USE_EXTERNAL=yes
LOGWRITES_DEV=/dev/loop15
--
Chandan
