> +extern int xlog_print_trans_attri_name(char **ptr, uint src_len, > + const char *tag); > +extern int xlog_print_trans_attri_value(char **ptr, uint src_len, int value_len, > + const char *tag); Maybe drop the pointless externs? Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>
