On Mon, Jul 01, 2024 at 05:57:23PM -0700, Darrick J. Wong wrote: > case sizeof(uint32_t): > - irec->ino_un.ex_data->counted_nlinks.un32[ino_offset]++; > + if (irec->ino_un.ex_data->counted_nlinks.un32[ino_offset] != XFS_NLINK_PINNED) Avoid the long line here. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>