On Mon, Jun 24, 2024 at 08:04:21 AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@xxxxxxxxxx>
>
> Implement FITRIM for the realtime device by pretending that it's
> "space" immediately after the data device. We have to hold the
> rtbitmap ILOCK while the discard operations are ongoing because there's
> no busy extent tracking for the rt volume to prevent reallocations.
>
Darrick, This patch causes generic/260 to fail in configuration using a
realtime device as shown below,
export TEST_DEV=/dev/loop0
export TEST_DIR=/mnt/test
export TEST_RTDEV=/dev/loop2
export SCRATCH_DEV=/dev/loop1
export SCRATCH_MNT=/mnt/scratch
export SCRATCH_RTDEV=/dev/loop3
export USE_EXTERNAL=yes
MOUNT_OPTIONS='-o usrquota,grpquota,prjquota'
export MKFS_OPTIONS="-i nrext64=1 -m rmapbt=0,reflink=0 -d rtinherit=1"
Here is the test execution log,
# ./check generic/260
RECREATING -- xfs on /dev/loop0
FSTYP -- xfs (debug)
PLATFORM -- Linux/x86_64 fstest 6.10.0-rc5-gb62c1dbbb6cb #9 SMP PREEMPT_DYNAMIC Thu Jun 27 11:51:06 IST 2024
MKFS_OPTIONS -- -f -rrtdev=/dev/loop3 -i nrext64=1 -m rmapbt=0,reflink=0 -d rtinherit=1 /dev/loop1
MOUNT_OPTIONS -- -o usrquota,grpquota,prjquota -ortdev=/dev/loop3 /dev/loop1 /mnt/scratch
generic/260 2s ... [failed, exit status 1]- output mismatch (see /root/repos/xfstests-dev/results//generic/260.out.bad)
--- tests/generic/260.out 2022-01-12 11:19:21.869941572 +0530
+++ /root/repos/xfstests-dev/results//generic/260.out.bad 2024-06-27 11:59:47.980946925 +0530
@@ -11,4 +11,5 @@
[+] Default length with start set (should succeed)
[+] Length beyond the end of fs (should succeed)
[+] Length beyond the end of fs with start set (should succeed)
+After the full fs discard 42871967744 bytes were discarded however the file system is 21474836480 bytes long.
Test done
...
(Run 'diff -u /root/repos/xfstests-dev/tests/generic/260.out /root/repos/xfstests-dev/results//generic/260.out.bad' to see the entire diff)
Ran: generic/260
Failures: generic/260
Failed 1 of 1 tests
--
Chandan
