Re: [PATCH 08/13] xfs: Do not free EOF blocks for forcealign

[John Garry <john.g.garry@xxxxxxxxxx>]

On 21/06/2024 20:08, Darrick J. Wong wrote:
> > diff --git a/fs/xfs/xfs_bmap_util.c b/fs/xfs/xfs_bmap_util.c
> > index e5d893f93522..56b80a7c0992 100644
> > --- a/fs/xfs/xfs_bmap_util.c
> > +++ b/fs/xfs/xfs_bmap_util.c
> > @@ -539,8 +539,13 @@ xfs_can_free_eofblocks(
> >   	 * forever.
> >   	 */
> >   	end_fsb = XFS_B_TO_FSB(mp, (xfs_ufsize_t)XFS_ISIZE(ip));
> > -	if (xfs_inode_has_bigrtalloc(ip))
> > +
> > +	/* Do not free blocks when forcing extent sizes */
> "Only try to free blocks beyond the allocation unit that crosses EOF" ?

ok, fine

> Otherwise seems fine to me
> Reviewed-by: Darrick J. Wong<djwong@xxxxxxxxxx>

cheers