s/this test/these tests/ ? > + if echo "$MKFS_OPTIONS" | grep -q 'parent='; then > + MKFS_OPTIONS="$(echo "$MKFS_OPTIONS" | sed -e 's/parent=[01]/parent=0/g')" Split the line? I also wonder if a generic helper to remove mkfs options might be useful. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>
