Darrick J. Wong <djwong@xxxxxxxxxx> 于2024年6月18日周二 12:23写道：
>
> On Tue, Jun 18, 2024 at 07:35:04PM +0800, Junchao Sun wrote:
> > By reordering the elements in the xfs_inode structure, we can
> > reduce the padding needed on an x86_64 system by 8 bytes.
>
>
> > Does this result in denser packing of xfs_inode objects in the slab
> > page?
No. Before applying the patch, the size of xfs_inode is 1800 bytes
with my config, and after applying the patch, the size is 1792 bytes.
This slight reduction does not result in a denser packing of xfs_inode
objects within a single page.
>
> --D
>
> > Signed-off-by: Junchao Sun <sunjunchao2870@xxxxxxxxx>
> > ---
> > fs/xfs/xfs_inode.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/xfs/xfs_inode.h b/fs/xfs/xfs_inode.h
> > index 292b90b5f2ac..3239ae4e33d2 100644
> > --- a/fs/xfs/xfs_inode.h
> > +++ b/fs/xfs/xfs_inode.h
> > @@ -40,8 +40,8 @@ typedef struct xfs_inode {
> > /* Transaction and locking information. */
> > struct xfs_inode_log_item *i_itemp; /* logging information */
> > struct rw_semaphore i_lock; /* inode lock */
> > - atomic_t i_pincount; /* inode pin count */
> > struct llist_node i_gclist; /* deferred inactivation list */
> > + atomic_t i_pincount; /* inode pin count */
> >
> > /*
> > * Bitsets of inode metadata that have been checked and/or are sick.
> > --
> > 2.39.2
> >
> >
--
Junchao Sun <sunjunchao2870@xxxxxxxxx>
