On Mon, Jun 10, 2024 at 09:50:33PM -0700, Christoph Hellwig wrote: > On Mon, Jun 10, 2024 at 02:07:23PM -0700, Darrick J. Wong wrote: > > It turns out that even this is still buggy because directories that are > > being inactivated (e.g. after repair has replaced the contents) can have > > zero isize. Sooo I'll have a new patch in a day or two. > > Isn't that what this patch checks for? Or do you mean inactivated > with non-zero nlink? Nah, there's another verifier check elsewhere that also trips when di-size == 0. > Btw, it might make sense to add a helper or local variable to check > for an unlinked dinode instead of open coding the v1 check twice in > this function. Maybe? But the logic is slightly different, isn't it? I'll have a look in the morning. --D
