> diff --git a/repair/progress.h b/repair/progress.h > index 0b06b2c4f43f..c09aa69413ac 100644 > --- a/repair/progress.h > +++ b/repair/progress.h > @@ -38,7 +38,7 @@ extern void summary_report(void); > extern int set_progress_msg(int report, uint64_t total); > extern uint64_t print_final_rpt(void); > extern char *timestamp(struct xfs_mount *mp, int end, int phase, char *buf); > -extern char *duration(time_t val, char *buf); > +char *duration(time_t val, char *buf) __attribute__((nonnull(2))); Once nonnull() is used here, shouldn't we also set -Wnonnull to CFLAGS? Please don't take it as a review, it's just a question that came to my mind as I don't fully understand the implications of using nonnull here. Carlos
