On Mon, May 20, 2024 at 06:46:23PM +0200, Andrey Albershteyn wrote: > As there are now FS_IOC_FS[GET|SET]XATTRAT ioctls, xfs_quota will > call them on special files. These new ioctls call > ->xfs_fileattr_set/get. Symlink inodes don't have operations to > set extended attributes, so add ones used by other inodes. The > attribute value combinations are checked in fileattr_set_prepare(). > > Signed-off-by: Andrey Albershteyn <aalbersh@xxxxxxxxxx> Seems fine to me Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx> --D > --- > fs/xfs/xfs_iops.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c > index ff222827e550..63f1a055a64a 100644 > --- a/fs/xfs/xfs_iops.c > +++ b/fs/xfs/xfs_iops.c > @@ -1199,6 +1199,8 @@ static const struct inode_operations xfs_symlink_inode_operations = { > .setattr = xfs_vn_setattr, > .listxattr = xfs_vn_listxattr, > .update_time = xfs_vn_update_time, > + .fileattr_get = xfs_fileattr_get, > + .fileattr_set = xfs_fileattr_set, > }; > > /* Figure out if this file actually supports DAX. */ > -- > 2.42.0 > >