On 2024-05-09 21:58:34, Christoph Hellwig wrote: > On Thu, May 09, 2024 at 05:15:00PM +0200, Andrey Albershteyn wrote: > > XFS has project quotas which could be attached to a directory. All > > new inodes in these directories inherit project ID. > > > > The project is created from userspace by opening and calling > > FS_IOC_FSSETXATTR on each inode. This is not possible for special > > files such as FIFO, SOCK, BLK etc. as opening them return special > > inode from VFS. Therefore, some inodes are left with empty project > > ID. > > > > This patch adds new XFS ioctl which allows userspace, such as > > xfs_quota, to set project ID on special files. This will let > > xfs_quota set ID on all inodes and also reset it when project is > > removed. > > Having these ioctls in XFS while the non-AT ones are in the VFS feels > really odd. What is the reason to make them XFS-specific? > I just don't see other uses for these in other fs, and in xfs it's just for project quota. So, I put them in XFS. But based on other feedback I will move them to VFS. -- - Andrey
