On Wed, May 01, 2024 at 02:25:19PM -0700, Darrick J. Wong wrote: > What happens if a shortform directory contains two entries to the same > file? I think @remove really means that the caller has verified that > the sf directory only contains one link @args->inumber? If that's so, > then the comment for this function should say that. No, I don't think there is such a validation. But given that i8count is 1 and the entry we are removing has a 4-byte inode when we call this, we can't by definition have two entries pointing to this inode, as then i8count would be 2. But I only thought about that now, and is is far to subtle (and I need to check if the above is true for whiteouts). I'll either clearly document it, or change it to a name comparison.
