On Mon, Apr 29, 2024 at 08:27:43AM -0700, Darrick J. Wong wrote: > On Mon, Apr 29, 2024 at 06:49:11AM +0200, Christoph Hellwig wrote: > > Accessing if_bytes without the ilock is racy. Remove the initial > > if_bytes == 0 check in xfs_reflink_end_cow_extent and let > > ext_iext_lookup_extent fail for this case after we've taken the ilock. > > > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > > I wonder if this has any practical (mal)effects on the system? No, just found by code audit. I though I did hit it but that was another bug, but in the process I did a somewhat paranoid audit.