On Mon, Apr 29, 2024 at 08:18:23AM -0400, Brian Foster wrote: > > Reported-by: Sam Sun <samsun1006219@xxxxxxxxx> > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > > --- > > The commit log/fixes tag are incorrect... xlog_logrec_hblks() didn't > exist at the time a70f9fe52daa was committed. I suspect this broke later > in commit 0c771b99d6c9 ("xfs: clean up calculation of LR header > blocks"), but please double check. Oh, indeed. My (git-)blame was a little too quick. Looking at that later commit: can xfs_sb_version_haslogv2 and the per-xlog_rec_header XLOG_VERSION_2 ever disagree? Do we need to check for that?