Hi all, this series addresses our long standing issue with confusing return values from xfs_bmapi_write. The first patch is the actual return value fix for the fuzzer-reported issue. The second to last patch cleans up and fixes long-standing issues in xfs_bmap_add_extent_delay_real in code paths that haven't been used much or at all. The last patch changes xfs_bmapi_write to not convert the entire delalloc extent if it hits one. This sounds simpler than it is, because delalloc conversion has been designed to always convert the entire extent since the initial delalloc commits. While this has gotten a bit more testing by now, this will still stress code never used. I've also looked into the alternative of having all callers handle short delalloc conversions, but it doesn't look appealing at all. Changes since v1: - rebased to the latest xfs-for-next tree with a minor conflict - spelling fixes
