On Thu, Apr 25, 2024 at 02:24:28PM +0100, John Garry wrote: > On 25/04/2024 13:17, Christoph Hellwig wrote: > > On Thu, Apr 25, 2024 at 12:08:45PM +0000, John Garry wrote: > > > + struct xfs_inobt_rec_incore __maybe_unused *irec; > > > > I've never seen code where __maybe_unused is the right answer, and this > > is no exception. > > Then what about 9798f615ad2be? Also not great and should be fixed. (it also wasn't in the original patch and only got added working around some debug warnings)
