On Tue, Apr 23, 2024 at 07:17:35PM +0800, Zhang Yi wrote: > + if ((flags & IOMAP_ZERO) && imap.br_startoff <= offset_fsb && > + isnullstartblock(imap.br_startblock)) { > + xfs_fileoff_t eof_fsb = XFS_B_TO_FSB(mp, XFS_ISIZE(ip)); > + > + if (offset_fsb >= eof_fsb) > + goto convert_delay; > + if (end_fsb > eof_fsb) { > + end_fsb = eof_fsb; > + xfs_trim_extent(&imap, offset_fsb, end_fsb - offset_fsb); Nit: overly long line here. I've also tried to to a more comprehensive review, but this depends on the rest of the series, which isn't in my linux-xfs folder for April. I've your're not doing and instant revision it's usually much easier to just review the whole series.