Hi Chandan, Please pull this branch with changes for xfs for 6.10-rc1. As usual, I did a test-merge with the main upstream branch as of a few minutes ago, and didn't see any conflicts. Please let me know if you encounter any problems. --D The following changes since commit 59a2af9086f0d60fc8de7346da67db7d764c7221: xfs: check parent pointer xattrs when scrubbing (2024-04-23 07:47:03 -0700) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git tags/repair-pptrs-6.10_2024-04-23 for you to fetch changes up to 327ed702d84034879572812f580cb769848af7ae: xfs: inode repair should ensure there's an attr fork to store parent pointers (2024-04-23 16:55:16 -0700) ---------------------------------------------------------------- xfs: online repair for parent pointers [v13.4 5/9] This series implements online repair for directory parent pointer metadata. The checking half is fairly straightforward -- for each outgoing directory link (forward or backwards), grab the inode at the other end, and confirm that there's a corresponding link. If we can't grab an inode or lock it, we'll save that link for a slower loop that cycles all the locks, confirms the continued existence of the link, and rechecks the link if it's actually still there. Repairs are a bit more involved -- for directories, we walk the entire filesystem to rebuild the dirents from parent pointer information. Parent pointer repairs do the same walk but rebuild the pptrs from the dirent information, but with the added twist that it duplicates all the xattrs so that it can use the atomic extent swapping code to commit the repairs atomically. This introduces an added twist to the xattr repair code -- we use dirent hooks to detect a colliding update to the pptr data while we're not holding the ILOCKs; if one is detected, we restart the xattr salvaging process but this time hold all the ILOCKs until the end of the scan. For offline repair, the phase6 directory connectivity scan generates an index of all the expected parent pointers in the filesystem. Then it walks each file and compares the parent pointers attached to that file against the index generated, and resyncs the results as necessary. This has been running on the djcloud for months with no problems. Enjoy! Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx> ---------------------------------------------------------------- Darrick J. Wong (16): xfs: remove some boilerplate from xfs_attr_set xfs: make the reserved block permission flag explicit in xfs_attr_set xfs: salvage parent pointers when rebuilding xattr structures xfs: add raw parent pointer apis to support repair xfs: repair directories by scanning directory parent pointers xfs: implement live updates for directory repairs xfs: replay unlocked parent pointer updates that accrue during xattr repair xfs: repair directory parent pointers by scanning for dirents xfs: implement live updates for parent pointer repairs xfs: remove pointless unlocked assertion xfs: split xfs_bmap_add_attrfork into two pieces xfs: add a per-leaf block callback to xchk_xattr_walk xfs: actually rebuild the parent pointer xattrs xfs: adapt the orphanage code to handle parent pointers xfs: repair link count of nondirectories after rebuilding parent pointers xfs: inode repair should ensure there's an attr fork to store parent pointers fs/xfs/libxfs/xfs_attr.c | 76 ++- fs/xfs/libxfs/xfs_attr.h | 3 +- fs/xfs/libxfs/xfs_bmap.c | 38 +- fs/xfs/libxfs/xfs_bmap.h | 3 +- fs/xfs/libxfs/xfs_dir2.c | 2 +- fs/xfs/libxfs/xfs_dir2.h | 2 +- fs/xfs/libxfs/xfs_parent.c | 64 +++ fs/xfs/libxfs/xfs_parent.h | 6 + fs/xfs/scrub/attr.c | 2 +- fs/xfs/scrub/attr_repair.c | 484 +++++++++++++++- fs/xfs/scrub/attr_repair.h | 4 + fs/xfs/scrub/dir_repair.c | 567 +++++++++++++++++- fs/xfs/scrub/findparent.c | 12 +- fs/xfs/scrub/findparent.h | 10 +- fs/xfs/scrub/inode_repair.c | 41 ++ fs/xfs/scrub/listxattr.c | 10 +- fs/xfs/scrub/listxattr.h | 4 +- fs/xfs/scrub/nlinks.c | 3 +- fs/xfs/scrub/orphanage.c | 38 ++ fs/xfs/scrub/orphanage.h | 3 + fs/xfs/scrub/parent.c | 7 +- fs/xfs/scrub/parent_repair.c | 1307 +++++++++++++++++++++++++++++++++++++++++- fs/xfs/scrub/scrub.c | 2 + fs/xfs/scrub/trace.h | 153 +++++ fs/xfs/xfs_xattr.c | 26 +- 25 files changed, 2743 insertions(+), 124 deletions(-)
