On Wed, Apr 24, 2024 at 10:06:38AM +0800, Jiapeng Chong wrote: > The function are defined in the dir_repair.c file, but not called > elsewhere, so delete the unused function. > > fs/xfs/scrub/dir_repair.c:186:1: warning: unused function 'xrep_dir_self_parent'. > > Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8867 > Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx> Yep, not used anywhere in my patchsets. Thank you for catching this and cleaning it up. Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx> --D > --- > fs/xfs/scrub/dir_repair.c | 21 --------------------- > 1 file changed, 21 deletions(-) > > diff --git a/fs/xfs/scrub/dir_repair.c b/fs/xfs/scrub/dir_repair.c > index 38957da26b94..f8450c7f99f4 100644 > --- a/fs/xfs/scrub/dir_repair.c > +++ b/fs/xfs/scrub/dir_repair.c > @@ -176,27 +176,6 @@ xrep_setup_directory( > return 0; > } > > -/* > - * If we're the root of a directory tree, we are our own parent. If we're an > - * unlinked directory, the parent /won't/ have a link to us. Set the parent > - * directory to the root for both cases. Returns NULLFSINO if we don't know > - * what to do. > - */ > -static inline xfs_ino_t > -xrep_dir_self_parent( > - struct xrep_dir *rd) > -{ > - struct xfs_scrub *sc = rd->sc; > - > - if (sc->ip->i_ino == sc->mp->m_sb.sb_rootino) > - return sc->mp->m_sb.sb_rootino; > - > - if (VFS_I(sc->ip)->i_nlink == 0) > - return sc->mp->m_sb.sb_rootino; > - > - return NULLFSINO; > -} > - > /* > * Look up the dotdot entry and confirm that it's really the parent. > * Returns NULLFSINO if we don't know what to do. > -- > 2.20.1.7.g153144c > >
