On Wed, Mar 20, 2024 at 07:05:45 PM +0800, Zhang Yi wrote: > From: Zhang Yi <yi.zhang@xxxxxxxxxx> > > Increase i_size in iomap_zero_range() and iomap_unshare_iter() is not > needed, the caller should handle it. Especially, when truncate partial > block, we should not increase i_size beyond the new EOF here. It doesn't > affect xfs and gfs2 now because they set the new file size after zero > out, it doesn't matter that a transient increase in i_size, but it will > affect ext4 because it set file size before truncate. So move the i_size > updating logic to iomap_write_iter(). > This patch causes generic/522 to consistently fail when using the following fstest configuration, TEST_DEV=/dev/loop16 TEST_LOGDEV=/dev/loop13 SCRATCH_DEV_POOL="/dev/loop5 /dev/loop6 /dev/loop7 /dev/loop8 /dev/loop9 /dev/loop10 /dev/loop11 /dev/loop12" MKFS_OPTIONS='-f -m reflink=1,rmapbt=1, -i sparse=1, -lsize=1g' MOUNT_OPTIONS='-o usrquota,grpquota,prjquota' TEST_FS_MOUNT_OPTS="$TEST_FS_MOUNT_OPTS -o usrquota,grpquota,prjquota" TEST_FS_MOUNT_OPTS="-o logdev=/dev/loop13" SCRATCH_LOGDEV=/dev/loop15 USE_EXTERNAL=yes LOGWRITES_DEV=/dev/loop15 -- Chandan
