Re: [PATCH 2/2] xfs_db: add helper for flist_find_type for clearer field matching

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 16, 2024 at 01:53:48PM -0700, Darrick J. Wong wrote:
> You could do:
> 
> 	if (!fa->subfld)
> 		goto out;
> 
> 	nfl = flist_find_ftyp(...);
> 
> to reduce the indenting here.  But I think you were trying to make
> before and after as identical as possible, right?

FYI, the goto version s what I had in mind with my original suggestion,
although the version here shoud be ok as well.  We'll need the static
either way, though.




[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux