On Tue, Apr 16, 2024 at 10:23:58PM +0200, Andrey Albershteyn wrote: > This is bunch of random fixes found by Coverity scan, there's memory > leak, truncation of time_t to int, access overflow, and freeing of > uninitialized struct. > > -- > Andrey Could you add a brief change history on patch 0/4 for v2? Besides that, the series looks fine to me and you can add: Reviewed-by: Bill O'Donnell <bodonnel@xxxxxxxxxx> > > Andrey Albershteyn (4): > xfs_db: fix leak in flist_find_ftyp() > xfs_repair: make duration take time_t > xfs_scrub: don't call phase_end if phase_rusage was not initialized > xfs_fsr: convert fsrallfs to use time_t instead of int > > db/flist.c | 4 +++- > fsr/xfs_fsr.c | 8 ++++++-- > repair/globals.c | 2 +- > repair/globals.h | 2 +- > repair/progress.c | 7 ++++--- > repair/progress.h | 2 +- > repair/xfs_repair.c | 2 +- > scrub/xfs_scrub.c | 3 ++- > 8 files changed, 19 insertions(+), 11 deletions(-) > > -- > 2.42.0 > >
