On Tue, Apr 16, 2024 at 09:29:09AM -0700, Christoph Hellwig wrote: > On Tue, Apr 16, 2024 at 08:49:32AM -0700, Darrick J. Wong wrote: > > > Not a fan of this, but I guess there is a real need somewhere because > > > we run out of the number of open fds otherwise? > > > > Yes, we can hit the open fd limit... > > > > > Given that repair > > > generally runs as root wouldn't it make more sense to just raise the > > > limit? > > > > ...and we /did/ raise the limit to whatever RLIMIT_NOFILE says is the > > maximum, but sysadmins could have lowered sysctl_nr_open on us, so we > > still ought to partition to try to avoid ENFILE on those environments. > > > > (Granted the /proc/sys/fs/nr_open default is a million, and if you > > actually have more than 500,000 AGs then either wowee you are rich!! or > > clod-init exploded the fs and you get what you deserve :P) > > Whar is clod-init? And where did you see this happen? cloud-init is a piece of software that cloud/container vendors install in the rootfs that will, upon the first startup, growfs the minified root image to cover the entire root disk. This is why we keep getting complaints about 1TB filesystems with 1,000 AGs in them. It's "fine" for ext4 because of the 128M groups, and completely terrible for XFS. (More generally it will also configure networking, accounts, and the mandatory vendor agents and whatnot.) --D