On Tue, Apr 16, 2024 at 09:05:55AM -0700, Darrick J. Wong wrote: > I prefer to keep the pptr version separate so that we can assert that > the args contents for parent pointers is really correct. We could do that with a merged version just as easily. > Looking at > xfs_attr_defer_parent again, it also ought to be checking that > args->valuelen == sizeof(xfs_getparents_rec); Yes.