On Mon, Apr 15, 2024 at 06:36:12PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong <djwong@xxxxxxxxxx> > > In preparation for online/offline repair wanting to use xfs_attr_set, > move some of the boilerplate out of this function into the callers. > Repair can initialize the da_args completely, and the userspace flag > handling/twisting goes away once we move it to xfs_attr_change. Not a huge fan of moving more into the weird attr_change wrapper that feels entirely misnamed and out of place. But if this gets us moving on the parent pointers it looks good enough: Reviewed-by: Christoph Hellwig <hch@xxxxxx> I'll probably do a pass on the higher level attr API at some point anyway to sort much of this out.
