Hi Chandan, Please pull this branch with changes for xfs for 6.10-rc1. As usual, I did a test-merge with the main upstream branch as of a few minutes ago, and didn't see any conflicts. Please let me know if you encounter any problems. --D The following changes since commit abf039e2e4afde98e448253f9a7ecc784a87924d: xfs: online repair of realtime summaries (2024-04-15 14:58:49 -0700) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git tags/dirattr-validate-owners-6.10_2024-04-15 for you to fetch changes up to fe6c9f8e48e0dcbfc3dba17edd88490c8579b34b: xfs: validate explicit directory free block owners (2024-04-15 14:58:52 -0700) ---------------------------------------------------------------- xfs: set and validate dir/attr block owners [v30.3 06/16] There are a couple of significant changes that need to be made to the directory and xattr code before we can support online repairs of those data structures. The first change is because online repair is designed to use libxfs to create a replacement dir/xattr structure in a temporary file, and use atomic extent swapping to commit the corrected structure. To avoid the performance hit of walking every block of the new structure to rewrite the owner number before the swap, we instead change libxfs to allow callers of the dir and xattr code the ability to set an explicit owner number to be written into the header fields of any new blocks that are created. For regular operation this will be the directory inode number. The second change is to update the dir/xattr code to actually *check* the owner number in each block that is read off the disk, since we don't currently do that. This has been running on the djcloud for months with no problems. Enjoy! Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx> ---------------------------------------------------------------- Darrick J. Wong (10): xfs: add an explicit owner field to xfs_da_args xfs: use the xfs_da_args owner field to set new dir/attr block owner xfs: reduce indenting in xfs_attr_node_list xfs: validate attr leaf buffer owners xfs: validate attr remote value buffer owners xfs: validate dabtree node buffer owners xfs: validate directory leaf buffer owners xfs: validate explicit directory data buffer owners xfs: validate explicit directory block buffer owners xfs: validate explicit directory free block owners fs/xfs/libxfs/xfs_attr.c | 14 ++-- fs/xfs/libxfs/xfs_attr_leaf.c | 60 +++++++++++--- fs/xfs/libxfs/xfs_attr_leaf.h | 4 +- fs/xfs/libxfs/xfs_attr_remote.c | 13 ++-- fs/xfs/libxfs/xfs_bmap.c | 1 + fs/xfs/libxfs/xfs_da_btree.c | 169 +++++++++++++++++++++++++++++++++++++++- fs/xfs/libxfs/xfs_da_btree.h | 3 + fs/xfs/libxfs/xfs_dir2.c | 5 ++ fs/xfs/libxfs/xfs_dir2.h | 4 + fs/xfs/libxfs/xfs_dir2_block.c | 42 +++++----- fs/xfs/libxfs/xfs_dir2_data.c | 18 +++-- fs/xfs/libxfs/xfs_dir2_leaf.c | 100 ++++++++++++++++++------ fs/xfs/libxfs/xfs_dir2_node.c | 44 ++++++----- fs/xfs/libxfs/xfs_dir2_priv.h | 15 ++-- fs/xfs/libxfs/xfs_exchmaps.c | 7 +- fs/xfs/scrub/attr.c | 1 + fs/xfs/scrub/dabtree.c | 8 ++ fs/xfs/scrub/dir.c | 23 +++--- fs/xfs/scrub/readdir.c | 6 +- fs/xfs/xfs_attr_item.c | 1 + fs/xfs/xfs_attr_list.c | 89 ++++++++++++++------- fs/xfs/xfs_dir2_readdir.c | 6 +- fs/xfs/xfs_trace.h | 7 +- 23 files changed, 492 insertions(+), 148 deletions(-)
