On Tue, Apr 09, 2024 at 11:06:33PM -0700, Christoph Hellwig wrote: > On Tue, Apr 09, 2024 at 06:01:51PM -0700, Darrick J. Wong wrote: > > From: Darrick J. Wong <djwong@xxxxxxxxxx> > > > > Add parent pointers to the list of supported features. > > Any reason to split this from actually adding the feature bit? Bisection. If we don't add the bit to XFS_SB_FEAT_INCOMPAT_ALL, then the kernel won't mount the filesystem. Nowadays I think we could define the xfs_has_foo helpers at the start and only add the superblock feature bit and the code that sets XFS_FEAT_FOO in the final patch. BUuut.... this patchset predates the xfs_has_foo helpers and I haven't fully adjusted to that yet. > Otherwise looks good: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> Thanks! --D
