On Tue, Apr 09, 2024 at 10:18:17PM -0700, Christoph Hellwig wrote: > On Tue, Apr 09, 2024 at 05:55:35PM -0700, Darrick J. Wong wrote: > > From: Darrick J. Wong <djwong@xxxxxxxxxx> > > > > Don't trip this assertion about attr log items if we have parent > > pointers enabled. Parent pointers are an incompat feature that doesn't > > use any of the functionality protected by > > XFS_SB_FEAT_INCOMPAT_LOG_XATTRS, which is why this is ok. > > I'd move the checks into the switch on op below, so that we check the log > attrs feature for the "normal" logged attrs and the parent pointers flag > for the parent pointer ops. Good idea. --D
