On Tue, Apr 9, 2024 at 9:22 AM Kees Cook <keescook@xxxxxxxxxxxx> wrote: > > > > - /* 1 larger than sb_fname, so this ensures a trailing NUL char */ > > - memset(label, 0, sizeof(label)); > > spin_lock(&mp->m_sb_lock); > > - strncpy(label, sbp->sb_fname, XFSLABEL_MAX); > > + strscpy_pad(label, sbp->sb_fname); > > Is sbp->sb_fname itself NUL-terminated? This looks like another case of > needing the memtostr() helper? > I sent a patch [1]. Obviously it depends on your implementation patch landing first; what tree should it go to? > Kees Cook [1]: https://lore.kernel.org/r/20240410-strncpy-xfs-split1-v2-1-7c651502bcb0@xxxxxxxxxx
