> + handle->ha_fid.fid_len = sizeof(struct xfs_fid) - > + sizeof(handle->ha_fid.fid_len); If we clean this up anyway, maybe add a helper for the above calculation and share it with xfs_khandle_to_dentry? Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>
