> + /* > + * Use the same dirent name hash as would be used on the directory, but > + * mix in the parent inode number. > + */ > + ret = xfs_dir2_hashname(mp, &xname); > + ret ^= upper_32_bits(parent_ino); > + ret ^= lower_32_bits(parent_ino); > + return ret; Totally superficial nit, but wouldn't this read a little nicer as: return xfs_dir2_hashname(mp, &xname) ^ lower_32_bits(parent_ino) ^ upper_32_bits(parent_ino); ? Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>
